Improvements #94
Open
Improvements #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project by dropping Node 18 support, improving configuration files, and adding type checking. The changes focus on enhancing code quality through better linting configuration and ensuring type safety.
- Dropped Node 18 from CI matrix
- Updated ESLint configuration to use TypeScript type-checking with project references
- Added null check for user authentication before folder creation
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/folderPane.ts | Added authentication guard to prevent folder creation when user is not logged in |
| package.json | Updated dependency versions to pre-release commits, reorganized scripts, and moved lint-staged to devDependencies |
| eslint.config.mjs | Modernized ESLint config with TypeScript type-checking and simplified structure |
| babel.config.js | Converted to ES module syntax |
| .github/workflows/ci.yml | Removed Node 18 from test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop node 18
better configs
typecheck